Adjust xcodeproj in react-native ios demo to use relative paths on CMake

[sskarz]

Adjust xcodeproj in react-native ios demo to use relative paths on CMake

Summary

This PR updates the Xcode project configuration in the react-native iOS demo to use relative paths for CMake references instead of hard-coded absolute paths. Additionally, the DEVELOPMENT_TEAM setting has been cleared. These changes improve the portability of the project and simplify the setup process for contributors using different environments.

Changes

• Relative Paths for CMake Toolchain:
  The absolute path to the iOS CMake toolchain:

  -DCMAKE_TOOLCHAIN_FILE="/Users/jh/dev/executorch/third-party/ios-cmake/ios.toolchain.cmake" \
  +DCMAKE_TOOLCHAIN_FILE="$PROJECT_DIR/../../../../../third-party/ios-cmake/ios.toolchain.cmake" \

  This change ensures that the toolchain reference is now relative to the project directory.

• Relative Paths for Third-party Dependencies:
  Updated the paths for third-party dependencies (abseil-cpp, re2, sentencepiece) from absolute paths like:

  -cmake_build "/Users/jh/dev/executorch/extension/llm/third-party/abseil-cpp" \
  +cmake_build "$PROJECT_DIR/../../../../../extension/llm/third-party/abseil-cpp" \

  This applies similarly to the other dependencies, allowing the project structure to be self-contained.

• Removal of Hard-coded DEVELOPMENT_TEAM:
  The DEVELOPMENT_TEAM value has been cleared:

  -DEVELOPMENT_TEAM = CLFN2N8XXS;
  +DEVELOPMENT_TEAM = "";

  This lets individual developers configure the appropriate team in their Xcode settings as needed.

Rationale

• Portability:
  Absolute paths can cause issues when the project is cloned or used in different environments. By switching to relative paths (using $PROJECT_DIR), we ensure that the project can be built regardless of where it is located on a filesystem.

• Customization:
  Removing the hard-coded DEVELOPMENT_TEAM value allows individual developers to configure their own team settings within Xcode, reducing potential conflicts and build errors.

Testing

• Tested on macOS Sequoia 15.1 | Conda 24.5.0 | Python 3.10.16

Thank you for reviewing this PR.

cc @shoumikhin @cbilgin

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8522

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 843344d with merge base fcb40f1 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @sskarz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[sskarz]

@pytorchbot label "release notes: build"

[orionr]

LGTM - thoughts @shoumikhin ?

[sskarz]

Why did the test fail here? Is there anything I need to do on my side to get this merged?

[mergennachin]

Why did the test fail here? Is there anything I need to do on my side to get this merged?

It might be a flaky test. I just reran that particular failed test. If it's green, feel free to merge

[sskarz]

Merging is blocked for me after rebase, I believe a maintainer has to merge it.

[mergennachin]

Merging