Log when a Result is created from Error::ok #8577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8577
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f793c88 with merge base 2fff01a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69870978 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 19, 2025
Summary: If this ctor is firing something has probably gone wrong. I found it a little hard to debug so adding logging to hopefully save someone else time in the future. Differential Revision: D69870978
JacobSzwejbka
force-pushed
the
export-D69870978
branch
from
17c97c8 to
39a3b02
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69870978 |
JacobSzwejbka
added a commit
to JacobSzwejbka/executorch-1
that referenced
this pull request
Feb 19, 2025
Summary: If this ctor is firing someone is probably returning Error::ok from a function that should return a Result not an Error. I found it a little hard to debug when this was happening so adding logging to hopefully save someone else time in the future. Differential Revision: D69870978
JacobSzwejbka
force-pushed
the
export-D69870978
branch
from
39a3b02 to
f172e2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69870978 |
Summary: If this ctor is firing someone is probably returning Error::ok from a function that should return a Result not an Error. I found it a little hard to debug when this was happening so adding logging to hopefully save someone else time in the future. Reviewed By: dbort Differential Revision: D69870978
JacobSzwejbka
force-pushed
the
export-D69870978
branch
from
f172e2b to
f793c88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69870978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: If this ctor is firing something has probably gone wrong. I found it a little hard to debug so adding logging to hopefully save someone else time in the future.
Differential Revision: D69870978