Skip to content

Use portable lib for finetuning demo #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

Use portable lib for finetuning demo #8613

merged 1 commit into from
Feb 25, 2025

Conversation

dpalmasan
Copy link
Contributor

Summary: Update the example of LLM fine-tuning on ET using portable_lib and XNNPack backend

Differential Revision: D69954671

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8613

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cfe0472 with merge base 9c51e58 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69954671

dpalmasan added a commit to dpalmasan/executorch that referenced this pull request Feb 21, 2025
@dpalmasan @facebook-github-bot
Use portable lib for finetuning demo (pytorch#8613)
6637610 
Summary:

Update the example of LLM fine-tuning on ET using portable_lib and XNNPack backend

Differential Revision: D69954671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69954671

swolchok
swolchok reviewed Feb 22, 2025
View reviewed changes
examples/llm_pte_finetuning/model_loading_lib.py Outdated
node.op == "call_function"
and node.target == torch.ops.aten.empty_permuted.out
):
print("find empty_permute: ", node)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think the past tense "found" is more typical for log output than the present tense "find"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Will update it, thanks!

JacobSzwejbka
JacobSzwejbka approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. cc @mergennachin who had been thinking about using a different repo for examples.

dpalmasan added a commit to dpalmasan/executorch that referenced this pull request Feb 24, 2025
@dpalmasan @facebook-github-bot
Use portable lib for finetuning demo (pytorch#8613)
6474058 
Summary:

Update the example of LLM fine-tuning on ET using portable_lib and XNNPack backend

Reviewed By: JacobSzwejbka

Differential Revision: D69954671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69954671

dpalmasan added a commit to dpalmasan/executorch that referenced this pull request Feb 24, 2025
@dpalmasan @facebook-github-bot
Use portable lib for finetuning demo (pytorch#8613)
a9ac4be 
Summary:

Update the example of LLM fine-tuning on ET using portable_lib and XNNPack backend

Reviewed By: JacobSzwejbka

Differential Revision: D69954671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69954671

@dpalmasan @facebook-github-bot
Use portable lib for finetuning demo (pytorch#8613)
cfe0472 
Summary:

Update the example of LLM fine-tuning on ET using portable_lib and XNNPack backend

Reviewed By: JacobSzwejbka

Differential Revision: D69954671
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69954671

@facebook-github-bot facebook-github-bot merged commit 745be4e into pytorch:main Feb 25, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok left review comments

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpalmasan @facebook-github-bot @swolchok @JacobSzwejbka