-
Notifications
You must be signed in to change notification settings - Fork 608
Arm backend: test_pipeline improvements #8644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add OpNotSupportedPipeline for checking that ops are not delegated properly. - Make use_to_edge_transform_and_lower default to true since this is the recommended API. - Rename TestPassPipeline -> PassPipeline to avoid warnings in pytest log, and make exir_ops optional as its not used then. - Allow to add the first non unique stage to a pipeline w/o suffix (E.g. run_method_and_compare_outputs will rarely be used twice even though it is theoretically possible, so we don't want to refer to it as run_method_and_compare_outputs.0 if not necessary). - Add custom_path option to all pipelines for easily dumping artifacts. - Typing and documentation fixes. Change-Id: Ic54f2691a5160259484d66f1c4c46a36f25733a4 Signed-off-by: Adrian Lundell <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8644
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 PendingAs of commit 263de21 with merge base b6bd89d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Unrelated errors:
|
@@ -152,10 +160,11 @@ def add_stage(self, func: Callable, *args, **kwargs): | |||
|
|||
suffix = str(len(stages_containing_stage_id)) | |||
|
|||
stage_id = stage_id + "." + suffix | |||
if not suffix == "0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suffix != "0". (this is not a bug, just odd; TIL that this definitely parses as not (suffix == "0")
)
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218