Skip to content

Enable quantized cat #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Enable quantized cat #8757

merged 1 commit into from
Feb 28, 2025

Conversation

mcremon-meta
Copy link
Contributor

Summary: As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: zonglinpeng

Differential Revision: D69499329

Copy link

pytorch-bot bot commented Feb 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8757

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 2 Pending

As of commit e032497 with merge base 316099f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

mcremon-meta added a commit that referenced this pull request Feb 27, 2025
Summary:

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: zonglinpeng

Differential Revision: D69499329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

mcremon-meta added a commit that referenced this pull request Feb 27, 2025
Summary:
Pull Request resolved: #8757

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: zonglinpeng

Differential Revision: D69499329
mcremon-meta added a commit that referenced this pull request Feb 27, 2025
Summary:

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: zonglinpeng

Differential Revision: D69499329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

mcremon-meta added a commit that referenced this pull request Feb 27, 2025
Summary:
Pull Request resolved: #8757

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: zonglinpeng

Differential Revision: D69499329
facebook-github-bot pushed a commit that referenced this pull request Feb 27, 2025
Summary:

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: tarun292, zonglinpeng

Differential Revision: D69499329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

facebook-github-bot pushed a commit that referenced this pull request Feb 27, 2025
Summary:

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: tarun292, zonglinpeng

Differential Revision: D69499329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

@mcremon-meta
Copy link
Contributor Author

mcremon-meta commented Feb 27, 2025

@dbort @mergennachin @tarun292 have you seen linter errors like this one? It doesn't seem to suggest a change, and linting on my own clone of ET (native mac) is clean. Not sure how to proceed.

@mergennachin
Copy link
Contributor

@mcremon-meta when you run locally, do you have the same lintrunner version as the CI?

https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner

@mcremon-meta
Copy link
Contributor Author

@mcremon-meta when you run locally, do you have the same lintrunner version as the CI?

https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner

yes I did those exact steps this morning, so should be the same

facebook-github-bot pushed a commit that referenced this pull request Feb 27, 2025
Summary:

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: tarun292, zonglinpeng

Differential Revision: D69499329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

mcremon-meta added a commit that referenced this pull request Feb 27, 2025
Summary:

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: tarun292, zonglinpeng

Differential Revision: D69499329
@mcremon-meta
Copy link
Contributor Author

might have been trailing spaces, let's see if new version is happy. If it's that it'd be nice if the linter message could say that, since the spaces don't show on the diff view (even when I highlight)

Summary:
Pull Request resolved: #8757

As titled. Use it only in the WakeWord quantizer for now, because it has implications on the numerics in general.

Reviewed By: tarun292, zonglinpeng

Differential Revision: D69499329
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D69499329

@facebook-github-bot facebook-github-bot merged commit 3ffd24e into main Feb 28, 2025
49 of 51 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D69499329 branch February 28, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants