Skip to content

Make flat_tensor depend on generated schema #8803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

Make flat_tensor depend on generated schema #8803

merged 1 commit into from
Feb 28, 2025

Conversation

swolchok
Copy link
Contributor

When passing -GNinja to cmake to build with Ninja, I was frequently getting errors that executorch/extension/flat_tensor/serialize/flat_tensor_generated.h was not found. This seems to fix them?

@swolchok
Update
5ce9b9d 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 28, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@swolchok swolchok requested a review from lucylq as a code owner February 28, 2025 00:11
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8803

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 5ce9b9d with merge base 316099f (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
swolchok added a commit that referenced this pull request Feb 28, 2025
@swolchok
Make flat_tensor depend on generated schema
984d57e 
When passing -GNinja to cmake to build with Ninja, I was frequently getting errors that executorch/extension/flat_tensor/serialize/flat_tensor_generated.h was not found. This seems to fix them?

ghstack-source-id: caaf6c8
ghstack-comment-id: 2689394542
Pull Request resolved: #8803
lucylq
lucylq approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swolchok
Copy link
Contributor Author

mac jobs had an issue yesterday, relying on linux unittest to demonstrate this is fine and landing

@swolchok swolchok merged commit 464bd9e into main Feb 28, 2025
48 of 51 checks passed
@swolchok swolchok deleted the gh/swolchok/295/head branch February 28, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swolchok @lucylq @facebook-github-bot