Skip to content

Cherrypick origin release 0.1 202310131648 #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 13, 2023
Merged

Cherrypick origin release 0.1 202310131648 #894

merged 15 commits into from
Oct 13, 2023

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Oct 13, 2023 •
edited
Loading

(base) mnachin@mnachin-mba executorch % python3 build/pick_doc_commits.py --release=origin/release/0.1

Remaining 'origin/main' commits that touch only documentation files; will be
cherry-picked into 'origin/release/0.1':

Cherry pick by running the commands:

git checkout origin/release/0.1
git cherry-pick \
  b448008daa1db0f257d13230a545abc4bba19e8d \
  fd2b256ddc0626acfa3903040fbb3a8173c87e64 \
  8beb217762a87b76e4200391ba9ac3f4a355d0b6 \
  ee958a4d021d5a723f8b6173ccbfa66164ff18f4 \
  469ee1cf045494c28f98f9f88808bfae3f052ce3 \
  52c8752dc1fefaa0bf55133dca2724b33240c2a0 \
  9880be6d9e17b22d81e0806fa7693ccf59fead4d \
  c1b533c5178fe60caa06581327b15ca0bc73813b
git checkout -b cherrypick-origin-release-0.1-202310131648

Then, push cherrypick-origin-release-0.1-202310131648 to GitHub:

git push --set-upstream origin cherrypick-origin-release-0.1-202310131648

When creating the PR, remember to set the 'into' branch to be 'release/0.1'.

mcr229 and others added 8 commits October 13, 2023 09:49
@mcr229 @mergennachin
tutorial update (#870)
81c1cc3 
Summary:
Pull Request resolved: #870

seems like we want to be using longterm apis now
D49972005

so updating docs to match such usage

Reviewed By: kirklandsign

Differential Revision: D50235705

fbshipit-source-id: c71b46fff333eac10e938cca922b6a32852d7b5c
@svekars @mergennachin
Add version dropdown to the layout html (#873)
f1f593d 
Summary:
Pull Request resolved: #873

Add the version dropdown to the layout html

Reviewed By: dbort

Differential Revision: D50238907

fbshipit-source-id: 6ffdacc8149d387275344973dd25643abc64c1d0
@Jack-Khuu @mergennachin
Fix ipynb generation (.md -> code block) (#862)
af518df 
Summary:
Pull Request resolved: #862

Currently everything is a .md block, which looks fine in html, but doesn't translate properly to .ipynb

This diff fixes the rendering to work in both html and ipynb

- Pushed code into code cells
- Adding mocking sphinx-gallery/sphinx-gallery#941 to get around runtime code not being run in Notebook
- Fixing inline code (.ipynb uses a different whitespace requirement than html sphinx)

Reviewed By: tarun292

Differential Revision: D50209589

fbshipit-source-id: deb1c2a8b52edce1783f042e10aa51bad7dd2516
@Jack-Khuu @mergennachin
Fix code block in .md for ipynb (#874)
ac54c43 
Summary:
Pull Request resolved: #874

ipynb uses different requirements for spacing than html/sphinx

This updates it to render properly

Reviewed By: tarun292, angelayi

Differential Revision: D50240561

fbshipit-source-id: a1aa6c1101b58b6239e1efda78ae34a61bc27ed1
@kirklandsign @mergennachin
Fix docs (#882)
18995a2 
Summary:
Pull Request resolved: #882

Address issues on T166442606
1. Make sure all python code snippet and bash commands can run.
2. Modify some links a bit.

Reviewed By: mcr229, shoumikhin

Differential Revision: D50250157

fbshipit-source-id: 67cf996df0967d89f2f87c8ab6a2604bc829f546
@tarun292 @mergennachin
Moving CMake build documentation to getting started section (#883)
1daf7f3 
Summary:
Pull Request resolved: #883

It feels like this makes more sense to have in the getting started section as people will want to get setup with CMake early on.

Reviewed By: larryliu0820, cccclai

Differential Revision: D50250770

fbshipit-source-id: ef4691a0396c4aa0ce0ff503080af00d23b7bcbd
@kimishpatel @mergennachin
Update how-it-works doc (#890)
8e8d3df 
Summary:
Pull Request resolved: #890

Makde some nit changes and update core opset section.

Reviewed By: mergennachin

Differential Revision: D50249026

fbshipit-source-id: ab97c217544e044897870302521cf9ef8569f003
@lucylq @mergennachin
Add concepts (#884)
818deff 
Summary:
Pull Request resolved: #884

Add some more concepts

Reviewed By: mergennachin

Differential Revision: D50250661

fbshipit-source-id: b94643c8878934e1d2435d77033fe9df34db1597
@mergennachin mergennachin requested a review from dbort October 13, 2023 16:56
@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Deploy Preview for resplendent-gnome-14e531 ready!

Name Link
🔨 Latest commit aaa55df
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/6529acbb8122230008f8d61e
😎 Deploy Preview https://deploy-preview-894--resplendent-gnome-14e531.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2023
@mergennachin mergennachin mentioned this pull request Oct 13, 2023
Closed
@dbort
Copy link
Contributor

dbort commented Oct 13, 2023

Thanks for creating this, looks good!

We might want to wait for #895 to land and include it in this PR; it fixes a bunch of broken links introduced by #883, which is also part of this PR. Or we could manually skip cherry picking #883 in this PR and grab it later once #895 is in.

@mergennachin
Copy link
Contributor Author

I will just wait then

@dbort
Copy link
Contributor

dbort commented Oct 13, 2023

#895 is in. I'll extend this PR with the most recent commits.

guangy10 and others added 7 commits October 13, 2023 13:46
@guangy10 @dbort
Fix link to the tutorial (#869)
5fe1107 
Summary:
Pull Request resolved: #869

As titled

Reviewed By: svekars

Differential Revision: D50232933

fbshipit-source-id: 9ece7bc65589ae0ece7ed06cc5240d8f8d6e4f81
@tarun292 @dbort
Rename getting-started-build-and-cross-compilation back to runtime-bu…
4b42b2e 
…ild-and-cross-compilation (#895)

Summary:
Pull Request resolved: #895

There are a bunch of files that are dependent on linking to runtime-build-and-cross-compilation so renaming it back. D50250770 was the original rename.

Reviewed By: dbort

Differential Revision: D50272497

fbshipit-source-id: 8c87dafd61ae36c9cddf2ca2a7f76c9f0dc8020f
@guangy10 @dbort
intro-overview (#893)
f719287 
Summary:
Pull Request resolved: #893

intro-overview improvement, since this is the first page users would see.

Reviewed By: mergennachin

Differential Revision: D50241879

fbshipit-source-id: 14cec4edb8342d3eb75608a7760748bed9be6be4
@kirklandsign @dbort
Use issue instead of TODO (#898)
0ed19ea 
Summary: Pull Request resolved: #898

Reviewed By: iseeyuan

Differential Revision: D50274388

fbshipit-source-id: 100af57af9b4fb563242d82b8178438757baaa22
@angelayi @dbort
Fix link (#899)
b479156 
Summary: Pull Request resolved: #899

Reviewed By: svekars

Differential Revision: D50275018

fbshipit-source-id: 1dfe3b9a8a31eba51a04c82c1aecf99a03509710
@guangy10 @dbort
getting-started-architecture.md (#900)
dfae01d 
Summary:
Pull Request resolved: #900

 - Fix links. Links are pretty much all wrong in this tutorial and some are failed links
 - rephrase

Reviewed By: JacobSzwejbka

Differential Revision: D50272977

fbshipit-source-id: 5f4d68dca0a6fa6022cc3e01a6ab3c2b809841b1
@JacobSzwejbka @dbort
patch some formating (#902)
aaa55df 
Summary:
Pull Request resolved: #902

title

Reviewed By: larryliu0820

Differential Revision: D50277351

fbshipit-source-id: cb6bf9f01831a21ceabf09b60bfaba3c180721f5
@dbort
Copy link
Contributor

dbort commented Oct 13, 2023 •
edited
Loading

For the record, I updated this by running:

git pull

# Note that I used this PR branch as the "release" to avoid re-cherry-picking commits already here
pick_doc_commits.py --release=origin/cherrypick-origin-release-0.1-202310131648

# Check out this PR's branch so I can cherry-pick onto it
git checkout cherrypick-origin-release-0.1-202310131648

# Do the cherry-picks recommended by the tool
git cherry-pick \
  e415d4b02196cda6601815481af3a095e2cbee47 \
  45108391cabd3036b412f212039d68a04c622114 \
  6e5b79e1466d2546018dfc311597c55b8efaa491 \
  a6667d3ff2daef40ed9027d43930d354abdbb5ac \
  6b303613688120ee1b076b383a02f64887565a4e \
  35639b85aa296a17c8358bfc619ea3aa6f8fd31a \
  d84b5fb1d0c1477a8ad9483551999d726ea0cb2e

# Push the updated PR branch
git push origin

@mergennachin mergennachin merged commit 4f91c39 into release/0.1 Oct 13, 2023
@mergennachin mergennachin deleted the cherrypick-origin-release-0.1-202310131648 branch October 13, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbort dbort dbort approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.