Skip to content

Rename module etdb to inspector #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Olivia-liu
Copy link
Contributor

Summary: Etdb directory was renamed, but because the Example usage is static, it didn't get updated

Differential Revision: D50282527

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for resplendent-gnome-14e531 ready!

Name Link
🔨 Latest commit d0d32ed
🔍 Latest deploy log https://app.netlify.com/sites/resplendent-gnome-14e531/deploys/6529bfa7aa7cd2000832f38a
😎 Deploy Preview https://deploy-preview-908--resplendent-gnome-14e531.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

@Olivia-liu Olivia-liu force-pushed the export-D50282527 branch 2 times, most recently from bc19f1d to e6b7104 Compare October 13, 2023 21:22
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

Summary:

Etdb directory was renamed, but because the Example usage is static, it didn't get updated

Reviewed By: Jack-Khuu

Differential Revision: D50282527
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50282527

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d71efe4.

dbort pushed a commit that referenced this pull request Oct 14, 2023
Summary:
Pull Request resolved: #908

Etdb directory was renamed, but because the Example usage is static, it didn't get updated

Reviewed By: tarun292, Jack-Khuu

Differential Revision: D50282527

fbshipit-source-id: 4839fcc74dc9c5905bfacfe30f4f199968c9541f
dbort pushed a commit that referenced this pull request Oct 15, 2023
Summary:
Pull Request resolved: #908

Etdb directory was renamed, but because the Example usage is static, it didn't get updated

Reviewed By: tarun292, Jack-Khuu

Differential Revision: D50282527

fbshipit-source-id: 4839fcc74dc9c5905bfacfe30f4f199968c9541f
mergennachin pushed a commit that referenced this pull request Oct 15, 2023
Summary:
Pull Request resolved: #908

Etdb directory was renamed, but because the Example usage is static, it didn't get updated

Reviewed By: tarun292, Jack-Khuu

Differential Revision: D50282527

fbshipit-source-id: 4839fcc74dc9c5905bfacfe30f4f199968c9541f
Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
Introduces basic Python dataclasses to represent requests, responses,
and associated objects defined in the OpenAI API specification. This
will enable creating a basic server that follows the spec so users can
leverage TorchChat to run LLMs on their own hardware with a familiar
interface to existing cloud tools.

**Testing**
Lintunner
```
lintrunner
Warning: Could not find a lintrunner config at: '.lintrunner.private.toml'. Continuing without using configuration file.

>>> Lint for generate.py:

  Advice (FLAKE8) C901
    'Generator.chat' is too complex (32)
    See https://www.flake8rules.com/rules/C901.html.

        581  |            buffer.clear()
        582  |        # print(, end='', flush=True)
        583  |
    >>> 584  |    def chat(
        585  |        self,
        586  |        generator_args: GeneratorArgs,
        587  |    ):
```
(advice from prior commit)

Dataclasses are used and tested further in PR #908
Gasoonjia pushed a commit that referenced this pull request Jul 30, 2024
Remove the existing browser UI and replace it with a UI built with Streamlit. This reduces complexity & leverages the functionality introduced in PR #906 to display chunked responses.

**Testing**
```
streamlit run torchchat.py -- browser stories110M --compile --max-new-tokens 256

  You can now view your Streamlit app in your browser.

  Local URL: http://localhost:8501
  Network URL: http://192.0.0.2:8501
```
<img width="1002" alt="image" src="https://github.com/user-attachments/assets/df305943-2326-4d01-a48b-61dd2006fa28">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants