Skip to content

Arm backend: Add MobileNet v3 testcase #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Conversation

tom-arm
Copy link
Collaborator

@tom-arm tom-arm commented Mar 13, 2025

  • Add missing inplace operators to quantization annotator.
  • Add atol, rtol & qtol to test_pipeline classes.

Co-authored-by: Oscar Andersson [email protected]
Signed-off-by: Tom Allsop [email protected]

Change-Id: Idca2bcfdaf8039430a73148e9742f747b03b3e6b

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@tom-arm tom-arm requested a review from digantdesai as a code owner March 13, 2025 11:25
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 13, 2025
Copy link

pytorch-bot bot commented Mar 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9223

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d775706 with merge base cb1d175 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tom-arm tom-arm added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels Mar 13, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet. Nice to see how easy it is to enable mv3 :)

@tom-arm
Copy link
Collaborator Author

tom-arm commented Mar 26, 2025

The failing jobs are unrelated

tom-arm added 2 commits March 26, 2025 17:17
* Add missing inplace operators to quantization annotator.
* Add atol, rtol & qtol to test_pipeline classes.

Co-authored-by: Oscar Andersson <[email protected]>
Signed-off-by: Tom Allsop <[email protected]>

Change-Id: Idca2bcfdaf8039430a73148e9742f747b03b3e6b
Change-Id: Ie2307d9f4238ce75aa816946b132330490c3a441
@zingo zingo force-pushed the add_mv3_testcase branch from c9963dc to d775706 Compare March 26, 2025 16:17
@tom-arm
Copy link
Collaborator Author

tom-arm commented Mar 27, 2025

The failing jobs are unrelated

@zingo zingo merged commit 8ee280b into pytorch:main Mar 27, 2025
164 of 165 checks passed
@tom-arm tom-arm deleted the add_mv3_testcase branch March 28, 2025 09:17
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
* Add missing inplace operators to quantization annotator.
* Add atol, rtol & qtol to test_pipeline classes.

Co-authored-by: Oscar Andersson <[email protected]>
Signed-off-by: Tom Allsop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants