Arm backend: Make passes preserve and update node metadata #9362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9362
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 713b82b with merge base feb3fcd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
facebook-github-bot
added
the
CLA Signed
zingo
approved these changes
Mar 20, 2025
digantdesai
reviewed
Mar 21, 2025
Comment on lines
+29
to
+30
| for key in keys: | ||
| new_meta[key] = meta[key] |
There was a problem hiding this comment.
I remember doing this manually, using
graph_module = super().call(graph_module).graph_module
When creating or updating nodes in passes, the metadata is not preserved nor updated correctly. This patch adds an ArmPass base class which may update the node metadata if super().call_operator(update=True) is used. It also adds functionality to arm_pass_utils.create_node() to update the node metadata. It will only update the 'stack_trace' field. All the other fields will be preserved from the original node. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I725dd057716ae5a1fac0f97b522df22196f00bdb
oscarandersson8218
force-pushed
the
passes_metadata
branch
from
7b23a0a to
7994719
Compare
zingo
approved these changes
Mar 31, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
When creating or updating nodes in passes, the metadata is not preserved nor updated correctly. This patch adds an ArmPass base class which may update the node metadata if super().call_operator(update=True) is used. It also adds functionality to arm_pass_utils.create_node() to update the node metadata. It will only update the 'stack_trace' field. All the other fields will be preserved from the original node. Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating or updating nodes in passes, the metadata is not preserved nor updated correctly. This patch adds an ArmPass base class which may update the node metadata if super().call_operator(update=True) is used. It also adds functionality to arm_pass_utils.create_node() to update the node metadata. It will only update the 'stack_trace' field. All the other fields will be preserved from the original node.
cc @digantdesai @freddan80 @per @zingo