Skip to content

Remove proprietary license #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neuropilot-captain
Copy link
Collaborator

Summary

  • Removed MTK proprietary header: NeauronAdapter.h from repo. Need to be downloaded from NeuroPilot Express SDK.\
  • Modify license declaration in multiple header.

Fix #9279

Copy link

pytorch-bot bot commented Mar 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9389

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 19, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergennachin can you take a look?

@@ -1,2385 +0,0 @@
/* Copyright Statement:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to delete this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we have to move this file to NP Express SDK because it is a MTK proprietary header

@neuropilot-captain
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@mergennachin
Copy link
Contributor

thanks @neuropilot-captain for the PR.

Three things:

@neuropilot-captain
Copy link
Collaborator Author

Hi @mergennachin, thanks for reviewing this PR.

  1. We have removed the license in the latest patch
    1. The users will have to copy the header to api directory from NeuroPilot Express SDK. We have updated the README for this. The header will be added to the SDK by this month

@mergennachin
Copy link
Contributor

Okay, I will merge this PR, as this unblocks the license issue.

But consider a few options moving, as this hinders user adoption experience:

  • Automatic script that does necessary stepping the SDK, including the copying .h file.
  • Provide a very thin integration header .h file that has more permissible license, and contains only the public API definitions, without any proprietary stuff that can be in any open source repo. And still have a proprietary .h file in the SDK, that defines proprietary stuff.

@mergennachin mergennachin merged commit 33f08c1 into pytorch:main Mar 20, 2025
4 checks passed
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
### Summary
- Removed MTK proprietary header: NeauronAdapter.h from repo. Need to be
downloaded from NeuroPilot Express SDK.\
- Modify license declaration in multiple header.

Fix pytorch#9279

---------

Co-authored-by: Poyuan Jeng <[email protected]>
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
### Summary
- Removed MTK proprietary header: NeauronAdapter.h from repo. Need to be
downloaded from NeuroPilot Express SDK.\
- Modify license declaration in multiple header.

Fix pytorch#9279

---------

Co-authored-by: Poyuan Jeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix license headers for MTK backend
5 participants