-
Notifications
You must be signed in to change notification settings - Fork 607
Remove proprietary license #9389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove proprietary license #9389
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9389
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mergennachin can you take a look?
@@ -1,2385 +0,0 @@ | |||
/* Copyright Statement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended to delete this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have to move this file to NP Express SDK because it is a MTK proprietary header
@pytorchbot label "topic: not user facing" |
thanks @neuropilot-captain for the PR. Three things:
|
Hi @mergennachin, thanks for reviewing this PR.
|
Okay, I will merge this PR, as this unblocks the license issue. But consider a few options moving, as this hinders user adoption experience:
|
### Summary - Removed MTK proprietary header: NeauronAdapter.h from repo. Need to be downloaded from NeuroPilot Express SDK.\ - Modify license declaration in multiple header. Fix pytorch#9279 --------- Co-authored-by: Poyuan Jeng <[email protected]>
### Summary - Removed MTK proprietary header: NeauronAdapter.h from repo. Need to be downloaded from NeuroPilot Express SDK.\ - Modify license declaration in multiple header. Fix pytorch#9279 --------- Co-authored-by: Poyuan Jeng <[email protected]>
Summary
Fix #9279