Skip to content

Remove tuple from module implementation #9519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

bsoyluoglu
Copy link
Contributor

@bsoyluoglu bsoyluoglu commented Mar 21, 2025

Summary: We do not want to have a wrapper to hold these values, the tensor object can provide them all on its own.

Reviewed By: shoumikhin

Differential Revision: D71658527

cc @shoumikhin @cbilgin

Summary: We do not want to have a wrapper to hold these values, the tensor object can provide them all on its own.

Reviewed By: shoumikhin

Differential Revision: D71658527
@bsoyluoglu bsoyluoglu requested a review from shoumikhin as a code owner March 21, 2025 23:48
Copy link

pytorch-bot bot commented Mar 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9519

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 7 Pending

As of commit 24dec27 with merge base cedf52a (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71658527

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@shoumikhin
Copy link
Contributor

@pytorchbot label "topic: not user facing"

@shoumikhin shoumikhin added module: ios Issues related to iOS code, build, and execution and removed topic: not user facing labels Mar 21, 2025
@facebook-github-bot facebook-github-bot merged commit 0dd7e4e into pytorch:main Mar 22, 2025
83 of 91 checks passed
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
Differential Revision: D71658527

Pull Request resolved: pytorch#9519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: ios Issues related to iOS code, build, and execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants