Support alpha in scalar add/sub cases #9703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9703
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 662089f with merge base 01f5599 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D71949902 |
mcremon-meta
added a commit
that referenced
this pull request
Mar 27, 2025
Summary: Support was missing from a previous diff, adding it here. Remove floor divide optimizations because they're wrong. We can add them later if we need them. Differential Revision: D71949902
mcremon-meta
force-pushed
the
export-D71949902
branch
from
cc34a9c to
e512b98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71949902 |
mcremon-meta
added a commit
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: #9703 Support was missing from a previous diff, adding it here. Remove floor divide optimizations because they're wrong. We can add them later if we need them. Differential Revision: D71949902
mcremon-meta
force-pushed
the
export-D71949902
branch
from
e512b98 to
b1cd9db
Compare
mcremon-meta
added a commit
that referenced
this pull request
Mar 27, 2025
Summary: Support was missing from a previous diff, adding it here. Remove floor divide optimizations because they're wrong. We can add them later if we need them. Differential Revision: D71949902
mcremon-meta
force-pushed
the
export-D71949902
branch
from
b1cd9db to
7e21eab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71949902 |
mcremon-meta
added a commit
that referenced
this pull request
Mar 27, 2025
Summary: Pull Request resolved: #9703 Support was missing from a previous diff, adding it here. Remove floor divide optimizations because they're wrong. We can add them later if we need them. Differential Revision: D71949902
mcremon-meta
force-pushed
the
export-D71949902
branch
from
7e21eab to
2692618
Compare
Summary: Support was missing from a previous diff, adding it here. Remove floor divide optimizations because they're wrong. We can add them later if we need them. Differential Revision: D71949902
facebook-github-bot
force-pushed
the
export-D71949902
branch
from
2692618 to
662089f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D71949902 |
zonglinpeng
approved these changes
Mar 27, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D71949902 Pull Request resolved: #9703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Support was missing from a previous diff, adding it here.
Remove floor divide optimizations because they're wrong. We can add them later if we need them.
Differential Revision: D71949902