Arm backend: Add support to eq.Scalar

[fumchin]

Implement eq.Scalar by converting to eq.Tensor using replace_scalar_with_tensor_pass and match_arg_ranks_pass.

• Convert eq.Tensor to eq.Scalar
• Expand test_eq to test both eq.Tensor and eq.Scalar

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9715

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d6cf513 with merge base d72ef5b ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[zingo]

Good work!

[kirklandsign]

Hi @zingo seems that it broke some of our internal tests.

cc @zonglinpeng for more contexts

[zonglinpeng]

Hi @zingo This diff breaks CI T219571006, introducing large loss in the model output. I verified the new eq scalar-to-tensor replacement caused the issue. Could you make make this replacement optional?

[zingo]

Thanks for notifying us, just for my understanding is this test on Arm delegate or other delegates?

We have a follow up PR where we internally discussing if we should move this change to only run on Arm delegate (its our Pow PR) and Im wondering if that will solve the problems you see or if we should investigate more?

As we cant see the test you run we can only guess. Thanks a lot for your help and initial triage.

[kirklandsign]

Hi @zingo, the broken test is on other delegates. Seems that this has impacts on all delegates? In this case, if we apply it to arm only, it would be ideal.

[zingo]

Thanks for the response, that good news and a fix is almost already prepared by @martinlsm that we can start with and figure out the Arm delegate later.

[zingo]

The PR we hope will fix this is merged now.
E g.
Add support for torch.pow in the Arm backend (PR #9309)

[zonglinpeng]

thanks @zingo I will try if PR #9309 fixes on my delegate, thank you @kirklandsign for clarifying!

[kirklandsign]

@zingo @zonglinpeng I tried applying this patch but seems that the test was not fixed

[martinlsm]

@kirklandsign Which delegate are you using? Is it possible for us at Arm to reproduce?

From our view #9309 reverts what this PR (#9715) introduced for other delegates than Arm's. Because this PR changed the ReplaceScalarWithTensor pass globally (and specifically the eq op in there) which #9309 then reverted. So we try to understand how other delegates are affected after #9309 did the revert.

[kirklandsign]

Hi @martinlsm the test is cadence backend. I am not sure how to repro, could @zonglinpeng provide context?

BTW seems that #9309 is not a clean revert of #9715 for that file. Is that related?

[zonglinpeng]

Thanks for checking in. I’m still running but some tests seems green on ci so should be good

…

On Wed, Apr 2, 2025 at 10:44 AM Hansong ***@***.***> wrote: Hi @martinlsm <https://github.com/martinlsm> the test is cadence backend. I am not sure how to repro, could @zonglinpeng <https://github.com/zonglinpeng> provide context? BTW seems that #9309 <#9309> is not a clean revert of #9715 <#9715> for that file. Is that related? — Reply to this email directly, view it on GitHub <#9715 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALBJ3VRE7UVDI6UQP3AHA2T2XQOX5AVCNFSM6AAAAABZ5DKLZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGI4DIMRXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: kirklandsign]*kirklandsign* left a comment (pytorch/executorch#9715) <#9715 (comment)> Hi @martinlsm <https://github.com/martinlsm> the test is cadence backend. I am not sure how to repro, could @zonglinpeng <https://github.com/zonglinpeng> provide context? BTW seems that #9309 <#9309> is not a clean revert of #9715 <#9715> for that file. Is that related? — Reply to this email directly, view it on GitHub <#9715 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALBJ3VRE7UVDI6UQP3AHA2T2XQOX5AVCNFSM6AAAAABZ5DKLZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZTGI4DIMRXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>