Skip to content

Arm backend: Make download of ethos-u dependencies optional #9734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

tobbeebbot
Copy link
Contributor

@tobbeebbot tobbeebbot commented Mar 28, 2025

Summary

This change makes the re-download of ethos-u dependencies optional during cmake configutation when building the executorch_runner.

If the user opts out it is assumed that the dependencies are already downloaded.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

This change makes the re-download of ethos-u dependencies
optional during cmake configutation when building the
executorch_runner.

If the user opts out it is assumed that the dependencies
are already downloaded.

Change-Id: I593fb640477dab0ceb9985eafbf3beb236fbd2a4
@tobbeebbot tobbeebbot requested a review from digantdesai as a code owner March 28, 2025 10:38
Copy link

pytorch-bot bot commented Mar 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9734

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d2ddcb8 with merge base 2d01dfc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 28, 2025
@tobbeebbot
Copy link
Contributor Author

@pytorchbot label ciflow/trunk

Copy link

pytorch-bot bot commented Mar 28, 2025

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@tobbeebbot
Copy link
Contributor Author

@pytorchbot label ciflow/trunk

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing labels Mar 28, 2025
@zingo zingo merged commit d72ef5b into pytorch:main Mar 28, 2025
171 of 175 checks passed
kirklandsign pushed a commit that referenced this pull request Apr 11, 2025
### Summary
This change makes the re-download of ethos-u dependencies optional
during cmake configutation when building the executorch_runner.

If the user opts out it is assumed that the dependencies are already
downloaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants