[CMake] Auto-detect C++ ABI version #321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like right now system is tune to only work with official nightly builds/gcc-7 (i.e. hardcodes ABI 11) Fixes pytorch/pytorch#103087
facebook-github-bot
added
the
CLA Signed
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kit1980
approved these changes
Jun 7, 2023
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 7, 2023
Use gcc9 in linux-bionic-cuda12_1-py3_10-gcc9-build workflows After PR, which fixed gcc9 transition : pytorch/multipy#321 <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at a076506</samp> This pull request updates the GCC version for Python 3.10 and CUDA 11.8/12.1 test images and removes the unused CUDA 12.1 image configuration and reference from the docker build scripts and workflow. Pull Request resolved: #103075 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like right now system is tune to only work with official nightly
builds/gcc-7 (i.e. hardcodes ABI 11)
Fixes pytorch/pytorch#103087