Skip to content

[sigmoid] fix for FX tracing unflattened modules #115708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[sigmoid] fix for FX tracing unflattened modules #115708

wants to merge 2 commits into from

Conversation

suo
Copy link
Member

@suo suo commented Dec 12, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D52095387

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Dec 12, 2023
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 12, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115708

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e3a836f with merge base 516bd4a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: PR #115708 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

suo added a commit that referenced this pull request Dec 13, 2023
@suo
[sigmoid] fix for FX tracing unflattened modules
1cd5f63 
Pull Request resolved: #115708

@bypass-github-pytorch-ci-checks

ghstack-source-id: 210062632
@exported-using-ghexport

Differential Revision: [D52095387](https://our.internmc.facebook.com/intern/diff/D52095387/)
@suo
Copy link
Member Author

suo commented Dec 13, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/suo/582/head branch December 17, 2023 15:25
guilhermeleobas pushed a commit to guilhermeleobas/pytorch that referenced this pull request Dec 18, 2023
@suo @guilhermeleobas
[sigmoid] fix for FX tracing unflattened modules (pytorch#115708)
65418d2 
Differential Revision: [D52095387](https://our.internmc.facebook.com/intern/diff/D52095387/)
Pull Request resolved: pytorch#115708
Approved by: https://github.com/zhxchen17
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@suo @dmenig
[sigmoid] fix for FX tracing unflattened modules (pytorch#115708)
778cf1a 
Differential Revision: [D52095387](https://our.internmc.facebook.com/intern/diff/D52095387/)
Pull Request resolved: pytorch#115708
Approved by: https://github.com/zhxchen17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhxchen17 zhxchen17 zhxchen17 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suo @facebook-github-bot @pytorchmergebot @zhxchen17