Skip to content

Set bash shell on Windows #128854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Set bash shell on Windows #128854

wants to merge 5 commits into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jun 17, 2024 •
edited
Loading

Attempt to fix the missing python3 command on the new Windows AMI https://github.com/pytorch/pytorch/actions/runs/9551494945/job/26325922503. I added the logic to copy python to python3 to make the command available, it worked with the previous AMI, but start to fail now and the cause is not clear (maybe it's not the AMI, but a new GitHub runner version)

@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request test-config/default labels Jun 17, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128854

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit b2b39c8 with merge base c6b180a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 17, 2024
This was referenced Jun 17, 2024
Closed
Closed
@huydhn huydhn changed the title Use python in the new Windows AMI (it's python3) Set bash shell on Windows Jun 17, 2024
@huydhn huydhn mentioned this pull request Jun 17, 2024
Closed
@huydhn huydhn marked this pull request as ready for review June 17, 2024 17:34
@huydhn huydhn requested a review from a team as a code owner June 17, 2024 17:34
@huydhn
Copy link
Contributor Author

huydhn commented Jun 17, 2024

I'll land this once windows build and test jobs finish successfully

malfet
malfet approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we specify it as default one for the platform?

@huydhn huydhn mentioned this pull request Jun 17, 2024
Closed
@huydhn
Copy link
Contributor Author

huydhn commented Jun 17, 2024

@pytorchbot merge -f 'CI-only fix. Force merge to fix trunk. Lint and windows jobs have passed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@nWEIdia
Copy link
Collaborator

nWEIdia commented Jun 17, 2024

Has #124613 been tested with Windows AMI before merging?

@huydhn
Copy link
Contributor Author

huydhn commented Jun 17, 2024

Has #124613 been tested with Windows AMI before merging?

cc @atalman

@atalman atalman mentioned this pull request Jun 18, 2024
Merged
atalman added a commit to pytorch/test-infra that referenced this pull request Jun 18, 2024
@atalman
Fix Install-Choco-GenerateProfile step (#5350)
df4c606 
Fixes the issue with AMI build when Miniconda variables in profile where
overwritten by
``
Install-Choco.ps1
``

Fixes the issue with Windows AMI:
pytorch/pytorch#128854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@huydhn @pytorchmergebot @nWEIdia @kit1980 @malfet @atalman