Skip to content

Propagate buffer and parameter indices through AOT #130393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Propagate buffer and parameter indices through AOT #130393

wants to merge 13 commits into from

Conversation

mlazos
Copy link
Contributor

@mlazos mlazos commented Jul 9, 2024 •
edited
Loading

@mlazos mlazos mentioned this pull request Jul 9, 2024
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130393

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c0bf205 with merge base 1d8baa4 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@mlazos mlazos mentioned this pull request Jul 9, 2024
Closed
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
504e05b 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@mlazos mlazos mentioned this pull request Jul 10, 2024
Closed
@mlazos mlazos requested a review from bdhirsh July 10, 2024 00:49
mlazos added a commit that referenced this pull request Jul 10, 2024
@mlazos
Propagate buffer and parameter indices through AOT
630c742 
ghstack-source-id: 7ba1cf8
Pull Request resolved: #130393
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
d477cab 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
04a9f29 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
4834936 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
mlazos added a commit that referenced this pull request Jul 10, 2024
@mlazos
Propagate buffer and parameter indices through AOT
2759a7e 
ghstack-source-id: 90b6a05
Pull Request resolved: #130393
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
56a48c0 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
49c287c 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
f85a8ce 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
@mlazos
Update on "Propagate buffer and parameter indices through AOT"
5808cd1 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jul 16, 2024
@mlazos @pytorchmergebot
Add buffer static input tests to cudagraph trees (#130402)
80236dc 
Pull Request resolved: #130402
Approved by: https://github.com/eellison
ghstack dependencies: #130391, #130392, #130503, #130393
@clee2000
Copy link
Contributor

@pytorchbot revert -m "broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace" -c landrace

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 16, 2024
@pytorchmergebot
Revert "Add buffer static input tests to cudagraph trees (#130402)"
9cb23ba 
This reverts commit 80236dc.

Reverted #130402 on behalf of https://github.com/clee2000 due to broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace ([comment](#130393 (comment)))
pytorchmergebot added a commit that referenced this pull request Jul 16, 2024
@pytorchmergebot
Revert "Propagate buffer and parameter indices through AOT (#130393)"
cbda8be 
This reverts commit 69a7738.

Reverted #130393 on behalf of https://github.com/clee2000 due to broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace ([comment](#130393 (comment)))
@pytorchmergebot
Copy link
Collaborator

@mlazos your PR has been successfully reverted.

@mlazos
Update on "Propagate buffer and parameter indices through AOT"
c0bf205 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 ColinPeppler amjames desertfire chauhang

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Jul 16, 2024
@mlazos @pytorchmergebot
Add buffer static input tests to cudagraph trees (#130402)
7919f0b 
Pull Request resolved: #130402
Approved by: https://github.com/eellison
ghstack dependencies: #130393
@henrylhtsang henrylhtsang mentioned this pull request Jul 17, 2024
Closed
mlazos added a commit that referenced this pull request Jul 18, 2024
@mlazos
Propagate buffer and parameter indices through AOT (#130393)
02318c6 
Pull Request resolved: #130393
Approved by: https://github.com/bdhirsh
ghstack dependencies: #130391, #130392, #130503
mlazos added a commit that referenced this pull request Jul 18, 2024
@mlazos
Add buffer static input tests to cudagraph trees (#130402)
871ffc9 
Pull Request resolved: #130402
Approved by: https://github.com/eellison
ghstack dependencies: #130391, #130392, #130503, #130393
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@pytorchmergebot @mlazos
Revert "Add buffer static input tests to cudagraph trees (#130402)"
61ae9f1 
This reverts commit 80236dc.

Reverted #130402 on behalf of https://github.com/clee2000 due to broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace ([comment](#130393 (comment)))
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@pytorchmergebot @mlazos
Revert "Propagate buffer and parameter indices through AOT (#130393)"
68abecd 
This reverts commit 69a7738.

Reverted #130393 on behalf of https://github.com/clee2000 due to broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace ([comment](#130393 (comment)))
mlazos added a commit that referenced this pull request Jul 18, 2024
@mlazos
Propagate buffer and parameter indices through AOT (#130393)
102c95b 
Pull Request resolved: #130393
Approved by: https://github.com/bdhirsh
mlazos added a commit that referenced this pull request Jul 18, 2024
@mlazos
Add buffer static input tests to cudagraph trees (#130402)
ee61997 
Pull Request resolved: #130402
Approved by: https://github.com/eellison
ghstack dependencies: #130393
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@mlazos @xuhancn
Propagate buffer and parameter indices through AOT (pytorch#130393)
4b81776 
Pull Request resolved: pytorch#130393
Approved by: https://github.com/bdhirsh
ghstack dependencies: pytorch#130391, pytorch#130392, pytorch#130503
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@mlazos @xuhancn
Add buffer static input tests to cudagraph trees (pytorch#130402)
85c34ef 
Pull Request resolved: pytorch#130402
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#130391, pytorch#130392, pytorch#130503, pytorch#130393
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@pytorchmergebot @xuhancn
Revert "Add buffer static input tests to cudagraph trees (pytorch#130402
d0467af 
)"

This reverts commit 80236dc.

Reverted pytorch#130402 on behalf of https://github.com/clee2000 due to broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace ([comment](pytorch#130393 (comment)))
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@pytorchmergebot @xuhancn
Revert "Propagate buffer and parameter indices through AOT (pytorch#1…
a7fe39a 
…30393)"

This reverts commit 69a7738.

Reverted pytorch#130393 on behalf of https://github.com/clee2000 due to broke lint for torch/_functorch/_aot_autograd/subclass_utils.py https://github.com/pytorch/pytorch/actions/runs/9948630877/job/27483551649 https://hud.pytorch.org/pytorch/pytorch/commit/80236dca90b0874cb2b6f9c9fa5f159c55726401 lint was green on PR, probably a landrace ([comment](pytorch#130393 (comment)))
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@mlazos @xuhancn
Propagate buffer and parameter indices through AOT (pytorch#130393)
45ffd75 
Pull Request resolved: pytorch#130393
Approved by: https://github.com/bdhirsh
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@mlazos @xuhancn
Add buffer static input tests to cudagraph trees (pytorch#130402)
96582b6 
Pull Request resolved: pytorch#130402
Approved by: https://github.com/eellison
ghstack dependencies: pytorch#130393
@github-actions github-actions bot deleted the gh/mlazos/53/head branch August 17, 2024 02:00
desai0007 pushed a commit to desai0007/test-repo-pytorch that referenced this pull request Feb 26, 2025
@mlazos
[Reland] Propagate buffer and parameter indices through AOT
89d4d16 
ghstack-source-id: 99b0f34
Pull Request resolved: pytorch/pytorch#130393
Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025
@mlazos
Propagate buffer and parameter indices through AOT
c104740 
ghstack-source-id: b4f0505
Pull Request resolved: pytorch/pytorch#130393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

Assignees
No one assigned
Labels
ciflow/inductor Merged module: dynamo module: inductor release notes: AO frontend Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlazos @clee2000 @pytorchmergebot @bdhirsh