Skip to content

remove vulkan sdk installation on executorch build #142424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove vulkan sdk installation on executorch build #142424

wants to merge 1 commit into from

Conversation

wdvr
Copy link
Contributor

@wdvr wdvr commented Dec 9, 2024 •
edited
Loading

pytorch-linux-jammy-py3-clang12-executorch started to fail today due to a 404 on the Vulkan SDK we use/download (1.2.198.1, 3 years old, URL: https://sdk.lunarg.com/sdk/download/1.2.198.1/linux/vulkansdk-linux-x86_64-1.2.198.1.tar.gz )

The Vulkan SDK is probably no longer needed for building Executorch, and is not used down the line for testing.

This PR tests removing the installation of the SDK

pytorch/executorch#7258

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142424

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit c1d4cfb with merge base beeffe7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn
huydhn approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jobs looks good now https://github.com/pytorch/pytorch/actions/runs/12246036693/job/34161201162

@huydhn huydhn marked this pull request as ready for review December 9, 2024 23:45
@huydhn huydhn requested a review from jeffdaily as a code owner December 9, 2024 23:45
@huydhn
Copy link
Contributor

huydhn commented Dec 10, 2024

@pytorchbot merge -f 'Lint and executorch jobs have passed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mori360 pushed a commit to mori360/pytorch that referenced this pull request Dec 11, 2024
@wdvr @mori360
remove vulkan sdk installation on executorch build (pytorch#142424)
963d48b 
pytorch-linux-jammy-py3-clang12-executorch [started to fail](https://github.com/pytorch/pytorch/actions/runs/12244909721/job/34157668780) today due to a 404 on the Vulkan SDK we use/download (1.2.198.1, 3 years old, URL: https://sdk.lunarg.com/sdk/download/1.2.198.1/linux/vulkansdk-linux-x86_64-1.2.198.1.tar.gz )

The Vulkan SDK is probably no longer needed for building Executorch, and is not used down the line for testing.

This PR tests removing the installation of the SDK

pytorch/executorch#7258
Pull Request resolved: pytorch#142424
Approved by: https://github.com/huydhn
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
@wdvr @bluenote10
remove vulkan sdk installation on executorch build (pytorch#142424)
6a2f7bc 
pytorch-linux-jammy-py3-clang12-executorch [started to fail](https://github.com/pytorch/pytorch/actions/runs/12244909721/job/34157668780) today due to a 404 on the Vulkan SDK we use/download (1.2.198.1, 3 years old, URL: https://sdk.lunarg.com/sdk/download/1.2.198.1/linux/vulkansdk-linux-x86_64-1.2.198.1.tar.gz )

The Vulkan SDK is probably no longer needed for building Executorch, and is not used down the line for testing.

This PR tests removing the installation of the SDK

pytorch/executorch#7258
Pull Request resolved: pytorch#142424
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the wdvr/remove-vulkan-sdk branch January 11, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
Merged module: vulkan topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wdvr @huydhn @pytorchmergebot