Skip to content

Pin Bump PT 20241002; Pin Bump ET to one using that PT pin #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Conversation

Jack-Khuu
Copy link
Contributor

@Jack-Khuu Jack-Khuu commented Oct 4, 2024

@Jack-Khuu Jack-Khuu requested review from kwen2501 and angelayi October 4, 2024 20:45
Copy link

pytorch-bot bot commented Oct 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1269

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 464c91d with merge base 6a2a2e8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 4, 2024
@Jack-Khuu Jack-Khuu requested a review from metascroy October 4, 2024 22:05
Copy link
Contributor

@kwen2501 kwen2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jack-Khuu
Copy link
Contributor Author

Updating AO to work with the new ET pin which marks API's as deprecated: pytorch/ao#1031

@Jack-Khuu
Copy link
Contributor Author

AO pin needs to be updated after the commit lands

@Jack-Khuu Jack-Khuu merged commit 286527c into main Oct 9, 2024
51 of 52 checks passed
@Jack-Khuu Jack-Khuu deleted the bump104 branch January 24, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants