Skip to content

Minor cleanup in torchchat/cli/builder.py #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Minor cleanup in torchchat/cli/builder.py #1308

merged 1 commit into from
Oct 18, 2024

Conversation

swolchok
Copy link
Contributor

Beautify a series of similar checks & fix a spelling error.

Beautify a series of similar checks & fix a spelling error.
Copy link

pytorch-bot bot commented Oct 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1308

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 16, 2024
@swolchok swolchok requested review from Jack-Khuu and mergennachin and removed request for Jack-Khuu October 16, 2024 22:27
Copy link
Contributor

@Jack-Khuu Jack-Khuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

cc: @kwen2501 on parallelize_model type

@Jack-Khuu Jack-Khuu merged commit fa6f9b6 into main Oct 18, 2024
51 checks passed
@swolchok swolchok deleted the builder-cleanup branch October 22, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants