Skip to content

Update install_requirements.sh #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

mikekgfb
Copy link
Contributor

After #1305 removed dependence on torchvision, this PR drops torchvision installation as part of install_requirements.sh

After pytorch#1305 removed dependence on torchvision, this PR drops torchvision installation as part of install_requirements.sh
Copy link

pytorch-bot bot commented Oct 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1310

Note: Links to docs will display an error until the docs builds have been completed.

❌ 24 New Failures, 1 Cancelled Job

As of commit 2905670 with merge base 8c75754 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2024
Remove any remaining dependences on torchvision in install_requirements.sh
@Jack-Khuu
Copy link
Contributor

Looks like torchtune is looking for torchvision, but isn't being pulled it in as part of tune itself: https://github.com/pytorch/torchchat/actions/runs/11409026850/job/31753111489?pr=1310

@ebsmothers Is this intended behavior or have we imported tune improperly?

@mikekgfb
Copy link
Contributor Author

Never mind, we need torchvision for torchtune (and importing it transitively), so removing the only import of torchvision in model.py is not sufficient to be able to remove torchvision from the list of packages we depend on.

@mikekgfb mikekgfb closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants