Bump torch pin to 20241010 #1400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As titled
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1400
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit de685b8 with merge base 47a0862 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
You'll need this change to get around the ggreganov BC break: torchchat/.github/workflows/pull.yml Line 734 in f38d3f4 |
|
Also ET pin needs to be bumped: https://github.com/pytorch/torchchat/blob/6e8bfb181a4afe11a919f29aac98eb3ae94ef424/install/.pins/et-pin.txt |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
See https://github.com/pytorch/torchchat/actions/runs/12204230280/job/34048909674?pr=1367 for a more recent bump |
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Bump torch pin to 20241010 As titled * bump ET and gguf Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled