Skip to content

Increment start_pos by encoded size in generate #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2025
+2 −0
Merged

Increment start_pos by encoded size in generate #1462

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0852578
Add encoded size to start_pos
Jan 16, 2025
e238a46
Only in chat mode
Jan 16, 2025
70ab45b
Merge branch 'main' into nlp/cache-start-pos
Jack-Khuu Jan 18, 2025
1a3af81
Merge branch 'main' into nlp/cache-start-pos
Jack-Khuu Jan 22, 2025
36dc78b
Merge branch 'main' into nlp/cache-start-pos
Jack-Khuu Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions torchchat/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,6 +1192,8 @@ def callback(x, *, done_generating=False):
max_seq_length=max_seq_length,
attention_backend=self.builder_args.attention_backend,
)
if generator_args.chat_mode:
start_pos += encoded.size(0)
for token_tensor, metrics in generator_func:
if token_tensor is not None:
start_pos += token_tensor.size(0)
Expand Down
Loading