Skip to content

Recover from aborted or failed model downloads #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2024
Merged

Recover from aborted or failed model downloads #358

merged 1 commit into from
Apr 21, 2024

Conversation

GregoryComer
Copy link
Member

Download model artifacts into a temporary directory (under .model-artifacts/download). Once download and conversion are complete, copy to the final location under .model-artifacts. This fixes an issue where the user could get "stuck" by having a partially downloaded model.

Test Plan:

# Recover from aborted download
rm -rf .model-artifacts/meta-llama/Meta-Llama-3-8B
python torchchat.py download llama3
(Abort via Ctrl-C partway through)
python torchchat.py generate llama3

# Test normal download path
rm -rf .model-artifacts/stories15M
python torchchat.py generate stories15M

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 21, 2024
@GregoryComer GregoryComer marked this pull request as ready for review April 21, 2024 21:57
mikekgfb
mikekgfb approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikekgfb mikekgfb merged commit a3d1efc into pytorch:main Apr 21, 2024
@mikekgfb mikekgfb deleted the download-recovery branch April 21, 2024 22:33
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Recover from aborted or failed model downloads (#358)
dfe95b7
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Recover from aborted or failed model downloads (#358)
ea78feb
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Recover from aborted or failed model downloads (#358)
8fc747a
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Recover from aborted or failed model downloads (#358)
0d0d9e2
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Recover from aborted or failed model downloads (#358)
aec6c38
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Recover from aborted or failed model downloads (#358)
2b83c7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekgfb mikekgfb mikekgfb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregoryComer @mikekgfb @facebook-github-bot