Skip to content

Doc fixes #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Doc fixes #371

merged 3 commits into from
Apr 23, 2024

Conversation

ali-khosh
Copy link
Contributor

Made some changes to the read me file. First time checking in to a repo at Meta so hopefully doing it right :)
This is updating my test PR with more changes :)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 22, 2024
@ali-khosh ali-khosh requested a review from byjlw April 22, 2024 07:47
@mikekgfb
Copy link
Contributor

What does "the following models are supported" mean? Ostensibly you can load other models like language llama, as long as you have a params.json and they fit into the architectural parameters ? (This is pre-existing and not a common on these edits that improve the exposition.)

Should we say tested - where do we discuss how to add new models?

Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikekgfb mikekgfb merged commit a5af214 into main Apr 23, 2024
@malfet malfet deleted the doc-fixes branch April 30, 2024 16:51
malfet pushed a commit that referenced this pull request Jul 17, 2024
* testing a small fix on the readme

* various fixes of README.md - ignoring sections that clearly look WIP

---------

Co-authored-by: Ali Khosh <[email protected]>
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
* testing a small fix on the readme

* various fixes of README.md - ignoring sections that clearly look WIP

---------

Co-authored-by: Ali Khosh <[email protected]>
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
* testing a small fix on the readme

* various fixes of README.md - ignoring sections that clearly look WIP

---------

Co-authored-by: Ali Khosh <[email protected]>
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
* testing a small fix on the readme

* various fixes of README.md - ignoring sections that clearly look WIP

---------

Co-authored-by: Ali Khosh <[email protected]>
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
* testing a small fix on the readme

* various fixes of README.md - ignoring sections that clearly look WIP

---------

Co-authored-by: Ali Khosh <[email protected]>
Co-authored-by: Michael Gschwind <[email protected]>
malfet pushed a commit that referenced this pull request Jul 17, 2024
* testing a small fix on the readme

* various fixes of README.md - ignoring sections that clearly look WIP

---------

Co-authored-by: Ali Khosh <[email protected]>
Co-authored-by: Michael Gschwind <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants