Skip to content

Revert "add --parallel-prefill options & option validation" #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

orionr
Copy link
Contributor

@orionr orionr commented Apr 22, 2024

Reverts #368

Broke a lot of tests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 22, 2024
@orionr orionr requested review from mikekgfb and byjlw April 22, 2024 13:51
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hold off on reverting this pr if t was indeed this pr!

@orionr
Copy link
Contributor Author

orionr commented Apr 22, 2024

Actually might have been the install_requirements.sh issue!

@orionr orionr closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants