[BE] Delay imports #377
Merged
[BE] Delay imports #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
facebook-github-bot
added
the
CLA Signed
orionr
approved these changes
Apr 22, 2024
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Do not import neither sentencepiece nor tiktoken until it is requested Same with HF hub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not import neither
sentencepiecenortiktokenuntil it is requestedSame with importing
HTTPErrorfrom requestsThis reduces time to run
python3 torchchat.py --helpfrom 2.29 to 1.58 sec