Skip to content

Fix download script location #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix download script location #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion scripts/workflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function download_checkpoint() {
if [ "$FORCE_DOWNLOAD" = true ] || [ ! -d "$CHECKPOINT_DIR" ] || [ -z "$(ls -A "$CHECKPOINT_DIR")" ]; then
echo "Download checkpoint for $MODEL_REPO"
rm -rf "$CHECKPOINT_DIR"
python3 scripts/download.py --repo-id "$MODEL_REPO"
python3 download.py --repo-id "$MODEL_REPO"
else
echo "Checkpoint directory for $MODEL_REPO is not empty. Skipping download."
fi
Expand All @@ -62,7 +62,17 @@ function run_validation_e2e() {

echo ""
echo "############### Validating ${MODEL_REPO##*/} ###############"

if [ ! -f "download.py" ]; then
echo "download.py doesn't exist."
exit 1
fi
download_checkpoint "$MODEL_REPO"

if [ ! -f "build/convert_hf_checkpoint.py" ]; then
echo "build/convert_hf_checkpoint.py doesn't exist."
exit 1
fi
bash .ci/scripts/convert_checkpoint.sh "$MODEL_REPO"

set +e
Expand Down