ET or AOTI backend logic #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Overall looks good. I can build on this for #393. |
metascroy
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Should maybe drop special logic in export.py for gguf (line 75-89) and rely on global state in builder.py alone.
There was a problem hiding this comment.
Eventually. But first we fix the implementation of operators.
added 2 commits
April 22, 2024 19:19
GregoryComer
approved these changes
Apr 23, 2024
| @@ -35,15 +35,17 @@ | |||
|
|
|||
|
|
|||
| def main(args): | |||
| # THIS BELONGS INTO CLI | |||
There was a problem hiding this comment.
I'll have a PR out to move this shortly.
malfet
approved these changes
Apr 23, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* ET or AOTI backend logic * use args, not builder_args * typo * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add global state logic to manage backends used by export.
This feature will be removed in the future and should not be relied on in long-term planning.