Skip to content

Refactor common download logic into cli.py #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2024
Merged

Refactor common download logic into cli.py #407

merged 1 commit into from
Apr 23, 2024

Conversation

GregoryComer
Copy link
Member

Introduce handle_common_args() in cli.py. Move model download call into handle_common_args.

Test Plan:

rm -rf .model-artifacts/stories15M
python torchchat.py generate storiest15M
# Test again now that the model is downloaded
python torchchat.py generate storiest15M

python torchchat.py eval stories15M
python torchchat.py export stories15M

@GregoryComer GregoryComer requested a review from mikekgfb April 23, 2024 05:36
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2024
mikekgfb
mikekgfb approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@GregoryComer GregoryComer merged commit bb96974 into main Apr 23, 2024
@GregoryComer GregoryComer deleted the download-cli-py branch April 23, 2024 06:21
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Refactor common download logic into cli.py (#407)
33e196e
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Refactor common download logic into cli.py (#407)
add7481
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Refactor common download logic into cli.py (#407)
2d012cb
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Refactor common download logic into cli.py (#407)
7d8de20
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Refactor common download logic into cli.py (#407)
bfd7186
malfet pushed a commit that referenced this pull request Jul 17, 2024
@GregoryComer @malfet
Refactor common download logic into cli.py (#407)
365cf56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekgfb mikekgfb mikekgfb approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregoryComer @mikekgfb @facebook-github-bot