Skip to content

Refactor tokenizer #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Refactor tokenizer #408

merged 4 commits into from
Apr 23, 2024

Conversation

larryliu0820
Copy link
Contributor

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2024
Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820
Copy link
Contributor Author

Verified failures not related

@larryliu0820 larryliu0820 merged commit c73b88a into main Apr 23, 2024
@malfet malfet deleted the refactor_tokenizer branch April 30, 2024 16:50
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
malfet pushed a commit that referenced this pull request Jul 17, 2024
* Refactor tokenizer

Summary: Prepare to add tiktoken

Test Plan:
Rely on CI jobs

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix more aoti

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

* Fix tokenizer read format

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants