-
Notifications
You must be signed in to change notification settings - Fork 250
adding run time info to eval and cleaning up output #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags:
Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags:
6c25922
to
83877e6
Compare
Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
mikekgfb
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
runner-et is a known issue, not related to the present PR. |
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* adding run time info to eval and cleaning up output Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags: * Adding evaluation.md content Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: * docs update Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* adding run time info to eval and cleaning up output Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags: * Adding evaluation.md content Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: * docs update Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* adding run time info to eval and cleaning up output Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags: * Adding evaluation.md content Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: * docs update Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* adding run time info to eval and cleaning up output Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags: * Adding evaluation.md content Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: * docs update Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* adding run time info to eval and cleaning up output Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags: * Adding evaluation.md content Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: * docs update Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* adding run time info to eval and cleaning up output Summary: output now includes info on model run time distribution and a cleaned up result output. Test Plan: python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth \ --dtype bfloat16 --device cuda \ Time to run eval: 53.31s. Time in model.forward: 20.29s, over 186 model evaluations forward run time stats - Median: 0.10s Min: 0.04s Max: 2.18s For model checkpoints/meta-llama/Llama-2-7b-hf/model.pth wikitext: word_perplexity,none: 9.1649 byte_perplexity,none: 1.5133 bits_per_byte,none: 0.5977 alias: wikitext Reviewers: Subscribers: Tasks: Tags: * Adding evaluation.md content Summary: see added content Test Plan: n/a Reviewers: Subscribers: Tasks: Tags: * docs update Summary: removing install instructions Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
output now includes info on model run time distribution and a cleaned up result output.
also added info to evaluation.md
Test Plan:
python eval.py --checkpoint-path checkpoints/$MODEL_REPO/model.pth
--dtype bfloat16 --device cuda \
Reviewers:
Subscribers:
Tasks:
Tags: