Remove tiktoken flag #426
Merged
Remove tiktoken flag #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Apr 23, 2024
Comment on lines
+356
to
+359
| t0 = time.time() | ||
| model = _load_model(builder_args, only_config=True) | ||
| device_sync(device=builder_args.device) | ||
| print(f"Time to load model: {time.time() - t0:.02f} seconds") |
There was a problem hiding this comment.
This code is repeated thrice in this PR. Can we have something like
with report_block-time("Time to load model"):
model = _load_model(builder_args, only_config=True)
device_sync(device=builder_args.device)
byjlw
approved these changes
Apr 23, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* remove need for toktoken flag * can't pass self to a function * remove toktoken cli flag * eliminate need to load entire model when we only need model.config
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* remove need for toktoken flag * can't pass self to a function * remove toktoken cli flag * eliminate need to load entire model when we only need model.config
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* remove need for toktoken flag * can't pass self to a function * remove toktoken cli flag * eliminate need to load entire model when we only need model.config
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* remove need for toktoken flag * can't pass self to a function * remove toktoken cli flag * eliminate need to load entire model when we only need model.config
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* remove need for toktoken flag * can't pass self to a function * remove toktoken cli flag * eliminate need to load entire model when we only need model.config
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* remove need for toktoken flag * can't pass self to a function * remove toktoken cli flag * eliminate need to load entire model when we only need model.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove tiktoken flag
prepare gguf load time reduction