-
Notifications
You must be signed in to change notification settings - Fork 250
[Android] Use prebuilts; add instructions for using them #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub artifacts (wether stored in GH own artifacts storage or in gha-artifacts.s3.amazonaws.com
) are not persistent, and technically can be recycled after 30 days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Changed to ossci-android bucket |
Addressed issue. Changed to ossci-android bucket.
@@ -25,6 +25,10 @@ else | |||
exit -1 | |||
fi | |||
|
|||
LLAMA_JNI_ARM64_URL="https://ossci-android.s3.us-west-1.amazonaws.com/executorch/release/0.2/arm64-v8a/libexecutorch_llama_jni.so" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do you know what are the restrictions for uploading/modifying files in that bucket? I'm not concerned if those binaries got compromised for CI system, but I would never install anything from that bucket on user system without hardcoding a checksum on the receiving side
See how it's done here for example (not advising a separate file for this one, just general workflow
https://github.com/pytorch/pytorch/blob/751d9a319d5e703c2b726d39a5711c0112ff5648/tools/linter/adapters/s3_init.py#L120
and https://github.com/pytorch/pytorch/blob/751d9a319d5e703c2b726d39a5711c0112ff5648/tools/linter/adapters/s3_init_config.json#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Huy: dev infra admins has permission to write to that bucket
* [Android] Use prebuilts; add instructions for using them * Use persistent S3
* [Android] Use prebuilts; add instructions for using them * Use persistent S3
* [Android] Use prebuilts; add instructions for using them * Use persistent S3
* [Android] Use prebuilts; add instructions for using them * Use persistent S3
* [Android] Use prebuilts; add instructions for using them * Use persistent S3
* [Android] Use prebuilts; add instructions for using them * Use persistent S3
No description provided.