Skip to content

[Android] Use prebuilts; add instructions for using them #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@kirklandsign kirklandsign requested a review from mikekgfb April 24, 2024 22:04
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 24, 2024
malfet
malfet previously requested changes Apr 24, 2024
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub artifacts (wether stored in GH own artifacts storage or in gha-artifacts.s3.amazonaws.com ) are not persistent, and technically can be recycled after 30 days

@kirklandsign kirklandsign requested a review from malfet April 25, 2024 00:24
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kirklandsign
Copy link
Contributor Author

GitHub artifacts (wether stored in GH own artifacts storage or in gha-artifacts.s3.amazonaws.com ) are not persistent, and technically can be recycled after 30 days

Changed to ossci-android bucket

@kirklandsign kirklandsign dismissed malfet’s stale review April 25, 2024 18:10

Addressed issue. Changed to ossci-android bucket.

@kirklandsign kirklandsign merged commit daac3e3 into main Apr 25, 2024
@@ -25,6 +25,10 @@ else
exit -1
fi

LLAMA_JNI_ARM64_URL="https://ossci-android.s3.us-west-1.amazonaws.com/executorch/release/0.2/arm64-v8a/libexecutorch_llama_jni.so"
Copy link
Contributor

@malfet malfet Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do you know what are the restrictions for uploading/modifying files in that bucket? I'm not concerned if those binaries got compromised for CI system, but I would never install anything from that bucket on user system without hardcoding a checksum on the receiving side

See how it's done here for example (not advising a separate file for this one, just general workflow
https://github.com/pytorch/pytorch/blob/751d9a319d5e703c2b726d39a5711c0112ff5648/tools/linter/adapters/s3_init.py#L120
and https://github.com/pytorch/pytorch/blob/751d9a319d5e703c2b726d39a5711c0112ff5648/tools/linter/adapters/s3_init_config.json#L11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Huy: dev infra admins has permission to write to that bucket

@kirklandsign kirklandsign deleted the android-use-prebuilt branch April 25, 2024 19:15
malfet pushed a commit that referenced this pull request Jul 17, 2024
* [Android] Use prebuilts; add instructions for using them

* Use persistent S3
malfet pushed a commit that referenced this pull request Jul 17, 2024
* [Android] Use prebuilts; add instructions for using them

* Use persistent S3
malfet pushed a commit that referenced this pull request Jul 17, 2024
* [Android] Use prebuilts; add instructions for using them

* Use persistent S3
malfet pushed a commit that referenced this pull request Jul 17, 2024
* [Android] Use prebuilts; add instructions for using them

* Use persistent S3
malfet pushed a commit that referenced this pull request Jul 17, 2024
* [Android] Use prebuilts; add instructions for using them

* Use persistent S3
malfet pushed a commit that referenced this pull request Jul 17, 2024
* [Android] Use prebuilts; add instructions for using them

* Use persistent S3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants