Skip to content

code refactor of documentation CI for advanced.md #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2024
Merged

code refactor of documentation CI for advanced.md #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3baa21a
code refactor
May 13, 2024
5bb1c20
typos
May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .ci/scripts/run-docs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,23 @@ if [ "$1" == "gguf" ]; then
echo "*******************************************"
bash -x ./run-gguf.sh
echo "::endgroup::"
<<<<<<< HEAD
fi


if [ "$1" == "advanced" ]; then
echo "::group::Create script to run advanced"
python3 scripts/updown.py --file docs/ADVANCED-USERS.md --replace 'llama3:stories15M,-l 3:-l 2,meta-llama/Meta-Llama-3-8B-Instruct:stories15M' --suppress huggingface-cli,HF_TOKEN > ./run-advanced.sh
# for good measure, if something happened to updown processor,
# and it did not error out, fail with an exit 1
echo "exit 1" >> ./run-advanced.sh
echo "::endgroup::"

echo "::group::Run advanced"
echo "*******************************************"
cat ./run-advanced.sh
echo "*******************************************"
bash -x ./run-advanced.sh
echo "::endgroup::"
echo "TBD"
fi
=======
fi
>>>>>>> e3db2486f80b71b3143945a44f58d50c02488c90

22 changes: 6 additions & 16 deletions .github/workflows/run-readme-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ jobs:
echo "*******************************************"
echo "::endgroup::"


test-advanced-any:
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
secrets: inherit
Expand All @@ -173,27 +174,15 @@ jobs:
export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH
echo "::endgroup::"

echo "::group::Create script to run advanced"
python3 scripts/updown.py --file docs/ADVANCED-USERS.md --replace 'llama3:stories15M,-l 3:-l 2,meta-llama/Meta-Llama-3-8B-Instruct:stories15M' --suppress huggingface-cli,HF_TOKEN > ./run-advanced.sh
# for good measure, if something happened to updown processor,
# and it did not error out, fail with an exit 1
echo "exit 1" >> ./run-advanced.sh
echo "::endgroup::"

echo "::group::Run advanced"
echo "*******************************************"
cat ./run-advanced.sh
echo "*******************************************"
bash -x ./run-advanced.sh
=======
.ci/scripts/run-docs advanced

echo "::group::Completion"
echo "tests complete"
echo "*******************************************"
>>>>>>> e3db2486f80b71b3143945a44f58d50c02488c90
echo "::endgroup::"

test-gguf-cpu:

test-advanced-cpu:
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
secrets: inherit
with:
Expand All @@ -212,9 +201,10 @@ jobs:
export PATH=/opt/rh/devtoolset-10/root/usr/bin/:$PATH
echo "::endgroup::"

TORCHCHAT_DEVICE=cpu .ci/scripts/run-docs gguf
TORCHCHAT_DEVICE=cpu .ci/scripts/run-docs advanced

echo "::group::Completion"
echo "tests complete"
echo "*******************************************"
echo "::endgroup::"