Skip to content

[BE] Replace copypasted with loops for arg parsing #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2024

Conversation

malfet
Copy link
Contributor

@malfet malfet commented May 13, 2024

At least for defining subparsers

At least for defining subparsers
Copy link

pytorch-bot bot commented May 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/787

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending

As of commit f7a1f11 with merge base 0aa93f7 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 13, 2024
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikekgfb mikekgfb merged commit 50e61b5 into main May 13, 2024
@malfet malfet deleted the malfet/be-kill-some-copypaste-code branch May 18, 2024 21:13
malfet added a commit that referenced this pull request Jul 17, 2024
* [BE] Replace copypasted with loops for arg parsing

At least for defining subparsers

* Fix loose reference
malfet added a commit that referenced this pull request Jul 17, 2024
* [BE] Replace copypasted with loops for arg parsing

At least for defining subparsers

* Fix loose reference
malfet added a commit that referenced this pull request Jul 17, 2024
* [BE] Replace copypasted with loops for arg parsing

At least for defining subparsers

* Fix loose reference
malfet added a commit that referenced this pull request Jul 17, 2024
* [BE] Replace copypasted with loops for arg parsing

At least for defining subparsers

* Fix loose reference
malfet added a commit that referenced this pull request Jul 17, 2024
* [BE] Replace copypasted with loops for arg parsing

At least for defining subparsers

* Fix loose reference
malfet added a commit that referenced this pull request Jul 17, 2024
* [BE] Replace copypasted with loops for arg parsing

At least for defining subparsers

* Fix loose reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants