Fix browser init #797
Merged
Fix browser init #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: Add CI that repeats above steps Fixes #785
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/797
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 5dfe3e9 with merge base 6a1400e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python3 torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: - Add CI that repeats above steps -Figure out if spawning generator from the browser can be avoided Fixes #785
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python3 torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: - Add CI that repeats above steps -Figure out if spawning generator from the browser can be avoided Fixes #785
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python3 torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: - Add CI that repeats above steps -Figure out if spawning generator from the browser can be avoided Fixes #785
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python3 torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: - Add CI that repeats above steps -Figure out if spawning generator from the browser can be avoided Fixes #785
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python3 torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: - Add CI that repeats above steps -Figure out if spawning generator from the browser can be avoided Fixes #785
malfet
added a commit
that referenced
this pull request
Jul 17, 2024
Update prompt chat is waiting for, which was modified by #476 Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few `prints` with `logging.info` This way, information about bandwith achieved will be printed to the console, but not to the web-browser chat window Test plan: ``` % python3 torchchat.py browser stories110M & % curl -L http://127.0.0.1:5000 % curl -d "prompt=Once upon a time" -X POST http://127.0.0.1:5000/chat ``` TODOs: - Add CI that repeats above steps -Figure out if spawning generator from the browser can be avoided Fixes #785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update prompt chat is waiting for, which was modified by #476
Modify logging defaults to not create a file in a temp folder without prompting user, but rather just print an info messages Replace few
printswithlogging.infoThis way, information about bandwith achieved will be printed to the console, but not to the web-browser chat windowTest plan:
TODOs:
-Figure out if spawning generator from the browser can be avoided
Fixes #785