Use int4mm weight packing MPS kernel #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/866
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0131b58 with merge base d71783c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Heads up that I have some PR's that'll land to fix most of these test (CI is just broke broke atm) |
malfet
approved these changes
Jun 25, 2024
|
so int4mm path for mps is enabled now? |
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Use int4mm weight packing mps kernel * update torch nightly Updating torch nightly to pick up int4mm groupsize 256 fix (#874)
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Use int4mm weight packing mps kernel * update torch nightly
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Use int4mm weight packing mps kernel * update torch nightly
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Use int4mm weight packing mps kernel * update torch nightly
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Use int4mm weight packing mps kernel * update torch nightly Updating torch nightly to pick up int4mm groupsize 256 fix (#874)
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Use int4mm weight packing mps kernel * update torch nightly Updating torch nightly to pick up int4mm groupsize 256 fix (#874)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should land after the following PyTorch PR lands: pytorch/pytorch#128965
in order to use the int4mm weight packing MPS kernel introduced there