[Dist][Inference] Further TP fix to make sure e2e TP is working #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/878
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 8df56df with merge base 7973c2a ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lessw2020
approved these changes
Jul 3, 2024
vmpuri
pushed a commit
that referenced
this pull request
Jul 8, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically we finally can test TP inference e2e. Although we still need to solve the issue when running generator via torchrun (how to handle input/output only through rank0), I was able to debug out and fixed the inference code using TP.