[Distributed]Integrate toml for configs, sink distributed launch & DCP work to distributed level #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/898
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be7db92 with merge base ceb9a3a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
fduwjj
reviewed
Jul 12, 2024
fduwjj
reviewed
Jul 12, 2024
fduwjj
approved these changes
Jul 12, 2024
|
Also please make sure all CI passed before merging, thanks! |
lessw2020
changed the title
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
vmpuri
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
…tributed launch & DCP work to distributed level (#898) * start inference.sh, toml configs * first toml * add config_manager * basic toml load, prep for starting dist * sink init and add toml parsing * toml load working * add distributed logger * logging working * ruff and isort * remove inference.py * better toml breakout, add tomli if python < 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
1 - adds toml support for distributed inference.
toml files can be spec'ed and stored in /inference_configs/llama3_8b.toml
at distributed launch the relevant toml file is loaded and parsed, and then used for distributed config esp pp and tp dimensions.
2 - moving the distributed launch code into world_maker.py in /distributed folder and simply exposing single api's to builder.py.
The idea here is to keep all code local to the distributed folder, and just expose surface apis to builder. This should make it easier to develop, as all code specific to distributed is local instead of interspersed between torchchat generic code (builder etc) and /distributed code.
3 - ruff and isort - ran ruff and isort to clean up current /distributed files.