Skip to content

Update quantize.py to use AO's int4 quantizer #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 19, 2024

Conversation

jackzhxng
Copy link
Contributor

Description

As a follow up from #882, remove duplicate code for WeightOnlyInt4QuantHandler and use TorchAO's respective API instead.

Test plan

Past existing tests.

@jackzhxng jackzhxng requested a review from larryliu0820 July 18, 2024 00:54
Copy link

pytorch-bot bot commented Jul 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/919

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 706a447 with merge base ab85b2a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 18, 2024
jackzhxng and others added 2 commits July 17, 2024 20:10
@Jack-Khuu
Copy link
Contributor

Looks great, thanks for working on this
Let's wait until #927 to land first

@larryliu0820 larryliu0820 merged commit 87798fd into main Jul 19, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants