Skip to content

Restore comment about getting stream info #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Restore comment about getting stream info #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/torchcodec/decoders/_core/VideoDecoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,11 @@ VideoDecoder::VideoDecoder(const void* buffer, size_t length) {
void VideoDecoder::initializeDecoder() {
TORCH_CHECK(!initialized_, "Attempted double initialization.");

// In principle, the AVFormatContext should be filled in by the call to
// avformat_open_input() which reads the header. However, some formats do not
// store enough info in the header, so we call avformat_find_stream_info()
// which decodes a few frames to get missing info. For more, see:
// https://ffmpeg.org/doxygen/7.0/group__lavf__decoding.html
int ffmpegStatus = avformat_find_stream_info(formatContext_.get(), nullptr);
if (ffmpegStatus < 0) {
throw std::runtime_error(
Expand Down
Loading