Skip to content

Fix the DCGAN C++ shape warning #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix the DCGAN C++ shape warning #3188

merged 1 commit into from
Dec 17, 2024

Conversation

LiAuTraver
Copy link
Contributor

@LiAuTraver LiAuTraver commented Dec 17, 2024

The issue in example repo has been fixed but on website it did not update. I found it today while following the tutorials.

Issue see here, main code repo PR: here.

This PR adopted the solution mentioned in the issue and tested with the latest version libtorch(current 2.5.1) with cuda 12.6.

cc @albanD @jbschlosser

Copy link

pytorch-bot bot commented Dec 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3188

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4120b1c with merge base 4a0ae38 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @LiAuTraver!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@svekars svekars added the core Tutorials of any level of difficulty related to the core pytorch functionality label Dec 17, 2024
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fair !
A squeeze(1) would also be ok here if we need the broadcasting to happen in the loss

@svekars svekars added the skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed. label Dec 17, 2024
@svekars svekars merged commit b8acfc8 into pytorch:main Dec 17, 2024
20 checks passed
vmoens pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality skip-link-check Will allow you to skip linkcheck on a PR. Should only should be used when a link can't be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants