Add more example for mix tasks config #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is caused by the fact that the code uses a simple `String.split(original_command, " ")` and treats the first token as the executable (base_command) and the rest as arguments. To allow using shell operators like `&&` or `||`, we can run everything in a shell. So instead of splitting the command, we hand off the entire string to the shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where commands chained with shell operators like
&&or||were not executed correctly.The problem was caused by splitting the command string with
String.split(original_command, " "), which treated operators as arguments.To fix this issue, the command is now passed directly to the shell for execution, allowing proper handling of shell operators.
Solves the error reported in #150