-
Notifications
You must be signed in to change notification settings - Fork 475
[qvs]add stopStream and delete check argument #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
============================================
+ Coverage 54.16% 54.28% +0.12%
- Complexity 696 715 +19
============================================
Files 94 96 +2
Lines 4667 4734 +67
Branches 506 506
============================================
+ Hits 2528 2570 +42
- Misses 1880 1909 +29
+ Partials 259 255 -4
Continue to review full report at Codecov.
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/test/java/test/com/qiniu/qvs/DeviceManagerTest.java
这个类下的test方法中没有加Assert,这样测试可能不会中止
建议都加下Assert,至少判断下状态码
可以参考:https://github.com/qiniu/java-sdk/blob/master/src/test/java/test/com/qiniu/storage/BucketTest.java#L51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1,新增停止流功能;
2,删除对传参start 和 end 的非法检查,服务端来直接判断;
3,修复启用、禁用和停止API的bug;
4,新增设备管理模块的功能;
5,更新空间管理的部分参数。