Skip to content

[qvs]add stopStream and delete check argument #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 11, 2020
Merged

[qvs]add stopStream and delete check argument #479

merged 12 commits into from
Sep 11, 2020

Conversation

HugoLipeng
Copy link
Contributor

@HugoLipeng HugoLipeng commented May 21, 2020

1,新增停止流功能;
2,删除对传参start 和 end 的非法检查,服务端来直接判断;
3,修复启用、禁用和停止API的bug;
4,新增设备管理模块的功能;
5,更新空间管理的部分参数。

@qiniu-bot qiniu-bot added size/L and removed size/S labels Aug 26, 2020
@qiniu-bot qiniu-bot added size/XL and removed size/L labels Aug 26, 2020
@qiniu-bot qiniu-bot added size/L and removed size/XL labels Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #479 into master will increase coverage by 0.12%.
The diff coverage is 65.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #479      +/-   ##
============================================
+ Coverage     54.16%   54.28%   +0.12%     
- Complexity      696      715      +19     
============================================
  Files            94       96       +2     
  Lines          4667     4734      +67     
  Branches        506      506              
============================================
+ Hits           2528     2570      +42     
- Misses         1880     1909      +29     
+ Partials        259      255       -4     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/qiniu/qvs/model/NameSpace.java 34.37% <33.33%> (-0.18%) 18.00 <3.00> (+3.00) ⬇️
src/main/java/com/qiniu/qvs/StreamManager.java 75.80% <42.85%> (+4.59%) 16.00 <0.00> (ø)
src/main/java/com/qiniu/qvs/model/Device.java 57.89% <57.89%> (ø) 9.00 <9.00> (?)
src/main/java/com/qiniu/qvs/NameSpaceManager.java 85.36% <60.00%> (+1.15%) 10.00 <0.00> (ø)
src/main/java/com/qiniu/qvs/DeviceManager.java 80.00% <80.00%> (ø) 11.00 <11.00> (?)
src/main/java/com/qiniu/qvs/QvsResponse.java 40.00% <0.00%> (-6.67%) 4.00% <0.00%> (-1.00%)
src/main/java/com/qiniu/storage/FormUploader.java 66.17% <0.00%> (-5.89%) 12.00% <0.00%> (-2.00%)
src/main/java/com/qiniu/common/QiniuException.java 41.66% <0.00%> (-4.17%) 5.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c045cd4...fc030d1. Read the comment docs.

@sjtuhyh
Copy link
Contributor

sjtuhyh commented Sep 2, 2020

LGTM

Copy link
Contributor

@peteryuanpan peteryuanpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/test/java/test/com/qiniu/qvs/DeviceManagerTest.java
这个类下的test方法中没有加Assert,这样测试可能不会中止
建议都加下Assert,至少判断下状态码
可以参考:https://github.com/qiniu/java-sdk/blob/master/src/test/java/test/com/qiniu/storage/BucketTest.java#L51

@qiniu-bot qiniu-bot added size/XL and removed size/L labels Sep 8, 2020
Copy link
Contributor

@longbai longbai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longbai longbai merged commit 99ef7e6 into master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants