添加日志报告 #331
Merged
添加日志报告 #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nighca
reviewed
Feb 24, 2018
src/index.js
Outdated
| @@ -9,8 +9,12 @@ import { | |||
| import { UploadManager } from "./upload"; | |||
| import { imageMogr2, watermark, imageInfo, exif, pipeline } from "./image"; | |||
| import { Observable } from "./observable"; | |||
| import {StatisticsLogger} from './statisticsLog' | |||
src/statisticsLog.js
Outdated
| if (xhr.readyState === 4) { | ||
| if (xhr.status !== 200) { | ||
| count++; | ||
| count <=3 ? xhr.send(this.info) : ""; |
There was a problem hiding this comment.
这样发的话，每次重试的时候发的都可能不是原来那个 info 了
src/utils.js
Outdated
| if (type === "http") { | ||
| return "80"; | ||
| } | ||
| return "443" |
src/upload.js
Outdated
| @@ -60,11 +65,37 @@ export class UploadManager { | |||
| } | |||
|
|
|||
| this.uploadUrl = getUploadUrl(this.config); | |||
| this.log ={ | |||
There was a problem hiding this comment.
log 信息太分散了，其实这里需要记的只有一个开始时间(uploadAt)，别的信息在 sendLog 里都能拿到的（uploadUrl, file.size, ...），不需要一个 this.log 的
src/upload.js
Outdated
| this.onError(err); | ||
| if(err.isRequestError && !this.config.disableStatisticsReport){ | ||
| if(err.code !== 0){ | ||
| this.log.code = err.code; |
There was a problem hiding this comment.
code 跟 reqId 一样通过 sendLog 传进去，不要一个通过 this.log.code = ...，一个通过 this.sendLog(...)
nighca
reviewed
Feb 24, 2018
src/upload.js
Outdated
| upload.then(res => { | ||
| this.onComplete(res.data); | ||
| if(!this.config.disableStatisticsReport){ | ||
| this.sendLog(res.reqId); |
nighca
reviewed
Feb 24, 2018
src/upload.js
Outdated
| remoteIp: "", | ||
| port: getPortFromUrl(this.uploadUrl), | ||
| duration: (new Date().getTime() - this.uploadAt)/1000, | ||
| time: parseInt(this.uploadAt/1000), |
There was a problem hiding this comment.
这边是为了取整吧？可以用 Math.floor 或者 Math.round，parseInt 本意不是做这个用的
src/statisticsLog.js
Outdated
| this.send(); | ||
| let logString = ""; | ||
| Object.keys(info).forEach(k => logString += info[k] + ","); | ||
| this.send(logString); |
nighca
reviewed
Feb 24, 2018
README.md
Outdated
| * config.useCdnDomain: 表示是否使用 cdn 加速域名，为布尔值，`true` 表示使用，默认为 `false` | ||
| * config.region: 选择上传域名区域，默认为(z0)华东 | ||
| * config.useCdnDomain: 表示是否使用 cdn 加速域名，为布尔值，`true` 表示使用，默认为 `false`。 | ||
| * config.disableStatisticsReport: 是否禁用日志报告，为布尔值，默认为`false`。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.