修复 sdk 最近的一些 issue #400
Merged
修复 sdk 最近的一些 issue #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
在 PR 描述里写 fix #xxx（ |
lzfee0227
reviewed
Feb 18, 2019
src/upload.js
Outdated
| @@ -273,8 +276,15 @@ export class UploadManager { | |||
| } | |||
|
|
|||
| finishDirectProgress(){ | |||
| @@ -273,8 +276,15 @@ export class UploadManager { | |||
| } | |||
|
|
|||
| finishDirectProgress(){ | |||
| // 在某些浏览器环境下，xhr 的 progress 事件无法被触发，progress 为 null， 这里 fake 下 | |||
| if (!this.progress) { | |||
There was a problem hiding this comment.
整体流程上看 progress 为 null 的情况确认只需要处理这一处吗？
记得之前出 bug 好像有不止一个地方会因为 progress 出 null 的问题的…
| @@ -231,12 +230,16 @@ export class UploadManager { | |||
| onProgress, | |||
| onCreate | |||
| }).then(response => { | |||
| // 在某些浏览器环境下，xhr 的 progress 事件无法被触发，progress 为 null，这里在每次分片上传完成后都手动更新下 progress | |||
| onProgress({ loaded: chunk.size }); | |||
There was a problem hiding this comment.
确认一下 progress 多触发一两次没问题吗？
另外触发顺序检查了吗？（确保 progress 一定是增的或者说不减的，并且一定在 complete 前触发）
| "es3ify-loader": "^0.2.0", | ||
| "open-browser-webpack-plugin": "0.0.5", | ||
| "qiniu-js": "^2.5.4", |
There was a problem hiding this comment.
是的，只有这个是单独有自己的node_modules
src/statisticsLog.js
Outdated
| xhr.open("POST", "https://uplog.qbox.me/log/3"); | ||
| xhr.setRequestHeader("Content-type", "application/x-www-form-urlencoded"); | ||
| xhr.setRequestHeader("Authorization", "UpToken " + token); | ||
| xhr.onreadystatechange = function () { | ||
| if (xhr.readyState === 4) { | ||
| if (xhr.status !== 200) { | ||
| count++; | ||
| count <= 3 ? xhr.send(logString) : ""; | ||
| } | ||
| count <= 3 ? self.send(logString, token) : ""; |
There was a problem hiding this comment.
3 这个 magic number 哪来的？
是配置项里的 retryCount 吗？
There was a problem hiding this comment.
不是, 这里它自己的重试，不过这里的确有点问题
added 2 commits
February 18, 2019 15:40
This was referenced Feb 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #411 fix #372 fix #386 fix #362
这次更改主要解决以下问题：