Skip to content

add badges of build, release and coverage #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

add badges of build, release and coverage #461

merged 1 commit into from
Jul 23, 2020

Conversation

zhongcj2020
Copy link

No description provided.

@CarlJi
Copy link
Contributor

CarlJi commented Jul 21, 2020

/assign @CarlJi

@zhongcj2020 zhongcj2020 force-pushed the open_jc_sdk branch 9 times, most recently from 319af1e to 3619078 Compare July 22, 2020 05:09
@qiniu-bot qiniu-bot added size/S and removed size/XS labels Jul 22, 2020
@qiniu-bot qiniu-bot added size/XS and removed size/S labels Jul 22, 2020
@zhongcj2020 zhongcj2020 force-pushed the open_jc_sdk branch 3 times, most recently from 307de5a to 7714b68 Compare July 22, 2020 08:28
@qiniu-bot qiniu-bot added size/S and removed size/XS labels Jul 22, 2020
@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@54557c0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #461   +/-   ##
=========================================
  Coverage          ?   39.64%           
=========================================
  Files             ?        7           
  Lines             ?      454           
  Branches          ?       95           
=========================================
  Hits              ?      180           
  Misses            ?      272           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54557c0...cbc90a8. Read the comment docs.

@CarlJi
Copy link
Contributor

CarlJi commented Jul 22, 2020

CodeCov上报了两次，不预期
image

@qiniu-bot qiniu-bot added size/XS and removed size/S labels Jul 22, 2020
@zhongcj2020
Copy link
Author

已修改好。
image

@winddies
Copy link
Contributor

@nighca 帮 merge 下

@nighca
Copy link
Contributor

nighca commented Jul 22, 2020

@surmon-china 帮瞅一眼这个？

surmon-china
surmon-china reviewed Jul 23, 2020
View reviewed changes
.travis.yml Outdated
script:
- npm run build
- jest --coverage
- codecov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- codecov
- npx codecov

建议使用 npx ，并移除 全局安装 (npm install -g codecov) 这一步骤，以减少上下文之间的关联

@zhongcj2020
Copy link
Author

已修改。

surmon-china
surmon-china approved these changes Jul 23, 2020
View reviewed changes
Copy link

@surmon-china surmon-china left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: surmon-china, zhongcj2020
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CarlJi CarlJi merged commit 7fa395c into qiniu:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlJi CarlJi CarlJi approved these changes

@surmon-china surmon-china surmon-china approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhongcj2020 @CarlJi @winddies @nighca @qiniu-bot @surmon-china